search

spring-cloud / spring-cloud-deployer-kubernetes

The Spring Cloud Deployer implementation for Kubernetes
Apache License 2.0
157 stars 97 forks source link

Upgrade cronjobs from v1beta1 to v1 #533

Closed SurajSharmaP closed 1 year ago

SurajSharmaP commented 1 year ago

This is to fix #529

I've changed the README to reflect the fact that cronjobs were stable from v1.21 so this change will effectively mean that v1.19 and v1.20 will not be supported fully anymore.

onobc commented 1 year ago

Thanks for the contribution @SurajSharmaP . The team needs to verify that the breaking change for 1.19 and 1.20 is acceptable before we merge this in. We should have an answer w/in a week. In the meantime, I noticed the CI is complaining about a checkstyle. If you get a chance to push an update that would be great. Thanks

SurajSharmaP commented 1 year ago

Thanks @onobc. Considering that EOL for 1.19 was more than a year ago, it should be easy to move forward with these changes

onobc commented 1 year ago

Hi @SurajSharmaP , While I would love nothing more than to support 1.21+ only, we have existing customers running on the older k8s versions. We discussed this in team meeting today but still need a bit more time to understand the impact of this change. Thanks for your patience.

corneil commented 1 year ago

Applied to 2.9.0-SNAPSHOT in https://github.com/spring-cloud/spring-cloud-deployer/pull/378