search

spring-cloud / spring-cloud-deployer

The Spring Cloud Deployer project defines an SPI for deploying long lived applications and short lived tasks
162 stars 87 forks source link

Task Launcher doesn't create Job as expected. #448

Open corneil opened 6 months ago

corneil commented 6 months ago

Description: Deploying a Task with CTR definition and launching as a job with ttl-seconds-after-finished doesn't apply the properties as expected. No Kubernetes Job is created. When the task is Scheduled then we do find that Jobs are created according to the schedule. However the ttlSecondsAfterFinished does not appear in the description of the Job.

Steps to reproduce Create a task with dsl timestamp && timestamp-batch Launch with the properties:

deployer.*.kubernetes.create-job=true
deployer.*.kubernetes.ttl-seconds-after-finished=120

Release versions: 2.11.2

cppwfs commented 6 months ago

SCDF currently sets this property globally for all apps spring.cloud.deployer.kubernetes.createJob. However, the deployer can be updated so that it can check for the deployer.kubernetes.create-job property and if present it will create the job (or not) based on the boolean value.

cppwfs commented 5 months ago

After further investigation, in order for SCDF to support the ability for a user to specify spring.cloud.deployer.kubernetes.create-job true or false for each task launch, we'd have to update SCDF to check both jobs and pods for deletions, log acquisition, creation(launching), retrieving task resources etc. You can view some of the changes required here: https://github.com/cppwfs/spring-cloud-deployer/tree/DEP-JOB-TASK