spring-cloud / spring-cloud-function

Apache License 2.0

1.04k stars 618 forks source link

Can't find the openwhisk sample #145

Closed csantanapr closed 6 years ago

csantanapr commented 6 years ago

From this site there is a link to openwhisk sample but the link is broken Site: https://cloud.spring.io/spring-cloud-function/#quick-start Link: https://github.com/spring-cloud/spring-cloud-function/tree/master/spring-cloud-function-samples/function-sample-openwhisk

kameshsampath commented 6 years ago

@csantanapr - here are two examples

https://github.com/kameshsampath/openwhisk-scf-docker (Docker Image)
https://github.com/kameshsampath/ow-scf-fruiteason - (POF example)
https://github.com/kameshsampath/ow-scf-greeter - (Spring Boot App example)

@dsyer - is it possible for document to point to these repos or can it be forked under spring-cloud-functions repo ?

dsyer commented 6 years ago

We could put a link in the README for the openwhisk adapter I guess, if you are planning on maintaining the samples. Send a PR and we can do that quickly. Longer term we might want to start a new project in github.com/spring-cloud-samples.

kameshsampath commented 6 years ago

@dsyer - where should we send the PR , README.adoc of this repo ?

dsyer commented 6 years ago

There's a readme in the ow adapter module (in this project) isn't there?

kameshsampath commented 6 years ago

oh yeah !! I can add them there to OW Adapter

kameshsampath commented 6 years ago

147 should solve this.

@dsyer - added the links to README, please feel free to mere when you are on it. thanks.

kameshsampath commented 6 years ago

thanks @dsyer for merging