search

spring-cloud / spring-cloud-kubernetes

Kubernetes integration with Spring Cloud Discovery Client, Configuration, etc...
Apache License 2.0
3.45k stars 1.03k forks source link

Repackage spring-cloud-kubernetes-configserver so that it can also be used as a dependency #1456

Open tspoeri opened 11 months ago

tspoeri commented 11 months ago

I am trying to add security to the spring-cloud-kubernetes-configserver, and the only way I see is to fork the project and add the necessary changes like dependencies and configuration.

It would be great if the spring-cloud-kubernetes-configserver was packaged in a way that it can be either directly launched as a service (the way it is today) or that it can also be used as a dependency for a custom built config server with enhanced functionality (similar to the spring-cloud-config-server on which it is based).

There seems to be a simple solution that only involves changing the classifier in the repackage goal of the build script that would allow both usages, as described here: https://stackoverflow.com/questions/40089443

ryanjbaxter commented 11 months ago

Makes sense, PRs welcome if you are interested