Update Config Watcher Configuration

wind57 commented 4 months ago

I want to extract some classes as individual auto configurations, because this will help me fix 1657. This PR does not do much, just extracts inner classes as separate auto-configuration ones @ryanjbaxter thank you for looking into it

ryanjbaxter commented 3 months ago

I guess I am confused on how these changes help fix the issue

ryanjbaxter commented 3 months ago

@wind57 see my comment above

wind57 commented 3 months ago

sorry, I missed that comment indeed. I had two ideas in my mind when creating this PR:

some time ago we had some nasty bugs with inner classes as configurations, so I decided to refactor things here, not to be in that position again.
the second one, related to the issues, is that I plan to not touch existing functionality too much. So I was thinking to have some Conditionals to differentiate between our existing implementation and the new one. If I separate configurations in this manner, it will be easier achieve that.

That is what I was leaning towards

ryanjbaxter commented 3 months ago

OK I am going to rename this issue since it is not actually directly addressing #1657.

wind57 commented 3 months ago

Perfect, thank you

spring-cloud / spring-cloud-kubernetes

Update Config Watcher Configuration #1660