spring-cloud / spring-cloud-kubernetes

Kubernetes integration with Spring Cloud Discovery Client, Configuration, etc...
Apache License 2.0
3.47k stars 1.04k forks source link

Refactor fabric8 catalog watch integration tests (1) #1755

Closed wind57 closed 1 month ago

wind57 commented 1 month ago

The main idea here is that I took an existing package of integration tests and re-factored it:

Logically, the tests have not changed at all, I changed the way we set-up thing.

On my laptop, running the previous version (time mvn clean install)

   ________________________________________________________
Executed in  378.78 secs    fish           external
   usr time   18.56 secs  104.00 micros   18.56 secs
   sys time    6.51 secs  708.00 micros    6.51 secs

and the current version:

Executed in  149.69 secs    fish           external
   usr time   23.64 secs   77.00 micros   23.64 secs
   sys time    5.78 secs  800.00 micros    5.78 secs
wind57 commented 1 month ago

@ryanjbaxter first IT refactor

wind57 commented 1 month ago

so what do you think? should I be looking at other integration tests that can be refactored in this manner?

ryanjbaxter commented 1 month ago

Yes! Sorry your response got lost in my email I think. Appreciate the effort here!