search

spring-cloud / spring-cloud-kubernetes

Kubernetes integration with Spring Cloud Discovery Client, Configuration, etc...
Apache License 2.0
3.47k stars 1.04k forks source link

Cleanup in it utilities 4 #1768

Closed wind57 closed 1 month ago

wind57 commented 1 month ago

@ryanjbaxter almost done with cleaning Commons, thank you.

ryanjbaxter commented 1 month ago

Why do we no longer need to call cleanup?

wind57 commented 1 month ago

this method is only used for our, spring-cloud images, and initially I thought that there are going to be so many integration tests that they will start eating up space, and we will need to cleanup. This was never the case, its actually in reverse, we try to lower the number of images we load via the refactoring work that was started.

In simpler words, this does the cleanup inside the K3S, but we do not need it at all. Besides that, it was never used in a consistent manner, some tests were using it, some not.

ryanjbaxter commented 1 month ago

Is it saving a lot of time?

wind57 commented 1 month ago

Tbh, no, not really. I just find it cleaner this way, we dont have to reason why that code is in place