search

spring-cloud / spring-cloud-kubernetes

Kubernetes integration with Spring Cloud Discovery Client, Configuration, etc...
Apache License 2.0
3.45k stars 1.03k forks source link

Modernize and update testing frameworks #236

Closed salaboy closed 2 years ago

salaboy commented 5 years ago

Upgrade and unify how we test the different modules.

geoand commented 5 years ago

Are we thinking of using Spock as a means of implementing this task?

I would gladly participate in such an implementation :)

salaboy commented 5 years ago

@geoand Spock is an option. It will be great to use the WebTestClient as well for doing real tests against services running inside Kubernetes. Mocking is good, but I will feel better with myself if we build a nice test suite that we can run also against running environments. Does this make sense?

geoand commented 5 years ago

@salaboy I already opened one PR concerning the WebTestClient (see this).

Just to make sure I understood correctly, you would like to add an integration test suite that stands up an actual Kubernetes cluster (something like Minikube for example) and performs the tests against it?

salaboy commented 5 years ago

@geoand Great stuff about the WebTestClient, Regarding starting a minikube, I wouldn't say so.. it should work with a real cluster that is already running somewhere.. so we can point the test suite against an environment.

geoand commented 5 years ago

@salaboy thanks :)

In my experience, finding such a cluster / environment against which we can run tests in CI is usually a problem :P Unless you mean we should have a suite of integration tests that don't run in CI, but instead can be run on demand by devs

spencergibb commented 5 years ago

I want to move away from groovy. That will influence decisions.

wind57 commented 2 years ago

@ryanjbaxter to me, this one can be closed?