search

spring-cloud / spring-cloud-kubernetes

Kubernetes integration with Spring Cloud Discovery Client, Configuration, etc...
Apache License 2.0
3.43k stars 1.03k forks source link

Should we replace fabric8 with https://github.com/kubernetes-client/java? #480

Open spencergibb opened 4 years ago

iocanel commented 4 years ago

Even though I am no longer actively involved with the fabric8 kubernetes-client, It's still my little baby, so I got to ask why?

spencergibb commented 4 years ago

More of a question really.

spencergibb commented 4 years ago

@iocanel can you give a few sentences to the advantages of the fabric8 one over the official client?

iocanel commented 4 years ago

why go fabric8

From my point of view the main advantage of the fabric8 kubernetes-client is the DSL which makes it much easier to use.

In additon to the DSL, it offers a mocking framework for the api server, which makes it really easy to write integration tests.

Last but not least, it does provide extensions for things like:

--

why go official

The official client uses a more automated approach, when it comes to generating the model. So, it does cover exotic resources, that in the fabric8 land are included upon request.

Even though the fabric8 client is IMHO way more user friendly, there are some edge cases (e.g. handling of CRDs) that used to simpler in the official client.

ryanjbaxter commented 4 years ago

I think for now we will leave it as is

ojhughes commented 4 years ago

@ryanjbaxter I think we should offer optional support for the official client using auto configuration. The official client is actively developed and they are working on Spring support [1]

1: https://github.com/kubernetes-client/java/tree/master/spring

ryanjbaxter commented 4 years ago

Awesome thanks!

spring-projects-issues commented 4 years ago

Closing due to age of the question. If you would like us to look at this issue, please comment and we will look at re-opening the issue.