spring-cloud / spring-cloud-kubernetes

Kubernetes integration with Spring Cloud Discovery Client, Configuration, etc...
Apache License 2.0
3.47k stars 1.03k forks source link

Add new module - Turbine discovery #90

Closed cmoulliard closed 5 years ago

cmoulliard commented 7 years ago

As NetFlix OSS proposes a nice solution to aggregate the streams of server send events - Turbine, we should integrate also the Turbine Discovery project developed under the Kubeflix github org within Spring Cloud Kuerbernetes in order to provide the Discovery feature when the application is running top of the kubernetes platform.

As we already offer such a feature for Ribbon & Hystrix, this is logic to provide it for Turbine too

spencergibb commented 7 years ago

spring-cloud-netflix has support for using turbine with CommonsInstanceDiscovery which s-c-k8s implements. Is there anything else needed?

cmoulliard commented 7 years ago

I will review the existing code to see if it fits our requirements implemented in TurbineDiscovery to grab the endpoints where the hystrix_enabled label is true

iocanel commented 7 years ago

The kubeflix turbine discovery module aimed, at non spring users. For spring users, using the discovery module of spring cloud kubernetes, should actually work (though I haven't tried it).

On the other hand, the kubeflix discovery module does have some extra goodies, like support cross namespace aggregation, filtering services by label etc. If it makes sense, to have those for spring cloud kubernetes I don't mind bringin that code over.

cmoulliard commented 7 years ago

According to our discussion, here are the actions that I propose to do :

spencergibb commented 5 years ago

Turbine has entered maintenance mode. This means that the Spring Cloud team will no longer be adding new features to the module. We will fix blocker bugs and security issues, and we will also consider and review small pull requests from the community.