spring-cloud / spring-cloud-netflix

Integration with Netflix OSS components
http://cloud.spring.io/spring-cloud-netflix/
Apache License 2.0
4.87k stars 2.44k forks source link

Document zuul filters for developers #1435

Closed spencergibb closed 7 years ago

spencergibb commented 8 years ago

@markfisher please add any specifics you'd like (like the lack of constants that are documented for map keys that you mentioned.)

markfisher commented 8 years ago

I think a detailed description of the RequestContext would be very useful. That should include any map keys that contribute to pre-established behavior as well as a thorough explanation of the way various methods on the context can influence response generation (for example, I seem to notice different behavior based on whether ctx.setResponseBody(..) has been called even if ctx.setResponseStatusCode(..) has been called with a status code that doesn't typically accompany a response body).

spencergibb commented 8 years ago

Mark Fisher [1:20 PM]
I think the most important thing would be to understand exactly what influences the request/response as well as the actual routing.... e.g. the "forward.to" key in the RequestContext and how that path resolves within the context of the current request

Mark Fisher [1:34 PM]
also would be good to have an overview of what's provided by ZuulProxyConfiguration which I believe is what determines most of the details I just mentioned in the last comment

spencergibb commented 7 years ago

Document different clients (OkHttp3, apache http client and ribbon rest client). Note which ribbon properties are only for ribbon restclient. SSL examples as well. See #1446

spencergibb commented 7 years ago

Here is my outline that I'm working on now:

spencergibb commented 7 years ago

Closed via d21d03b7387cdf481304806dd32927ac0b9cc4b1 and 675e4c1031b275af877938c02d5950c91f7fe660