search

spring-cloud / spring-cloud-netflix

Integration with Netflix OSS components
http://cloud.spring.io/spring-cloud-netflix/
Apache License 2.0
4.88k stars 2.44k forks source link

Port LocalApplicationHealthCheckHandler from sidecar to eureka-client #3744

Open Kirozen opened 4 years ago

Kirozen commented 4 years ago

Hello all,

Until now, I'm using spring-cloud-netflix-sidecar with the current release but after a quick look in the current development branch, it appears the module will be deleted in the next release (or soon). I'm embarrassed because I need a sidecar and I could not find any substitute. Do you have any suggestions? How will we continue to have a sidecar, which will work with spring cloud, for our applications?

Thanks in advance!

spencergibb commented 4 years ago

The previous sidecar was written with zuul and ribbon which are both removed in ilford. It would need to be rewritten using gateway and spring cloud load balancer. Marking for team discussion to see if this is something we want to support.

Kirozen commented 4 years ago

Thank you for your reactivity :-)

spencergibb commented 4 years ago

Now that I'm thinking about it. This would be just spring cloud gateway with spring cloud load balancer with some configuration. At that point it is just some documentation I think. It wouldn't live here anymore. Hoxton will be supported until at least June 2021. Off the top of my head I don't think there are any features missing.

spencergibb commented 4 years ago

After a bit more investigation there needs to be a replacement for [SidecarController(https://github.com/spring-cloud/spring-cloud-netflix/blob/2.2.x/spring-cloud-netflix-sidecar/src/main/java/org/springframework/cloud/netflix/sidecar/SidecarController.java)], see https://github.com/spring-cloud/spring-cloud-commons/pull/680. Also LocalApplicationHealthCheckHandler and LocalApplicationHealthIndicator need to be ported somewhere. I'll reopen to track LocalApplicationHealthCheckHandler as Health Indicator has been added in commons.

puneethps commented 3 years ago

Any updates on this?