search

spring-cloud / spring-cloud-netflix

Integration with Netflix OSS components
http://cloud.spring.io/spring-cloud-netflix/
Apache License 2.0
4.85k stars 2.43k forks source link

Switch remaining jUnit 4 tests to jUnit jupiter #4011

Open OlgaMaciaszek opened 3 years ago

SivaTharun commented 2 years ago

@OlgaMaciaszek can i work on this issue.

OlgaMaciaszek commented 2 years ago

@SivaTharun , thanks for reaching out. @maniotie is already working on this issue for now. If not all modules are converted, I will get back to you here.

OlgaMaciaszek commented 2 years ago

@maniotie is now working on reducing method and class visibility after the conversion to JUnitJupiter.

ThomasTopuz commented 4 months ago

Is anybody working on this?

OlgaMaciaszek commented 4 months ago

I don't think anybody is at the moment. They are only a few test left, but possibly the ones that were proving tricky during the previous work done by contributors. Would you like to work on it @ThomasTopuz ?

deii commented 3 weeks ago

The remaining tests use the deprecated ModifiedClassPathRunner class. It would be possible to replace it with ModifiedClassPathExtension, but this class has a package-access level. How could we solve this? Should I create an issue and patch in the spring-cloud-commons project?

https://github.com/spring-cloud/spring-cloud-commons/blob/main/spring-cloud-test-support/src/main/java/org/springframework/cloud/test/ModifiedClassPathExtension.java#L49

OlgaMaciaszek commented 2 weeks ago

Right, @deii. Have created: https://github.com/spring-cloud/spring-cloud-commons/pull/1358.

OlgaMaciaszek commented 2 weeks ago

It's merged now. @deii @ThomasTopuz Let me know if any of you would like to work on this.