search

spring-cloud / spring-cloud-netflix

Integration with Netflix OSS components
http://cloud.spring.io/spring-cloud-netflix/
Apache License 2.0
4.85k stars 2.43k forks source link

Fix basic auth with encoded characters (#3815) #4260

Closed ZIRAKrezovic closed 3 months ago

ZIRAKrezovic commented 4 months ago

Fixes: #3815

ZIRAKrezovic commented 3 months ago

Hi @OlgaMaciaszek, I have added a test. Although I'm not sure if it's the right approach, or if it can be done with unit tests without a server, it tests what this fix is supposed to fix.

ZIRAKrezovic commented 3 months ago

I have found out how Spring Webflux developers do the tests and updated my test accordingly.

https://github.com/spring-projects/spring-framework/blob/6.1.x/spring-webflux/src/test/java/org/springframework/web/reactive/function/client/DefaultWebClientTests.java#L128