search

spring-cloud / spring-cloud-netflix

Integration with Netflix OSS components
http://cloud.spring.io/spring-cloud-netflix/
Apache License 2.0
4.87k stars 2.44k forks source link

Add support for configuring RestTemplate via RestTemplateBuilder (#4255) #4262

Closed ZIRAKrezovic closed 6 months ago

ZIRAKrezovic commented 7 months ago

Fixes: #4255

ZIRAKrezovic commented 6 months ago

Thanks!

OlgaMaciaszek commented 6 months ago

@ZIRAKrezovic Did it, but the changes cause test failures (for some reason, the build was apparently not triggered on your PR). Will revert them - please resubmit your PR with fixed tests.

OlgaMaciaszek commented 6 months ago

@ZIRAKrezovic - see details: https://github.com/spring-cloud/spring-cloud-netflix/actions/runs/8440522374/job/23117589376. Some tests will need updating to the new API.

ZIRAKrezovic commented 6 months ago

Hi @OlgaMaciaszek. I did a rebase, applied your patch that fixes the copyright year and author, and fixed the compilation of the failed test.

OlgaMaciaszek commented 6 months ago

Thanks @ZIRAKrezovic .