search

spring-cloud / spring-cloud-netflix

Integration with Netflix OSS components
http://cloud.spring.io/spring-cloud-netflix/
Apache License 2.0
4.87k stars 2.44k forks source link

Collect metrics for application instances #4270

Closed heowc closed 5 months ago

heowc commented 6 months ago

Fixes #3685

OlgaMaciaszek commented 6 months ago

@jonatan-ivanov Could you please review the metrics-related code?

OlgaMaciaszek commented 6 months ago

Thanks a lot @jonatan-ivanov. @heowc please address the comments and don't hesitate to let us know if you need additional help.

OlgaMaciaszek commented 6 months ago

Thanks for updates, @heowc. It seems you're still working on it since there are TBD comments and not all the changes we've discussed have been implemented, I will not be reviewing it yet. Could you mark the PR as draft and then turn it back into regular PR once you're ready for review? Also, make sure to pull the changes from main and resolve existing conflicts. You can also add a comment for us to look at it when it's ready. If you have additional questions, also let us know. Please make sure you tag me in any comments so that we don't miss them.

OlgaMaciaszek commented 5 months ago

@jonatan-ivanov Could you please review the reworked metrics?

OlgaMaciaszek commented 5 months ago

Thanks a lot @jonatan-ivanov.