search

spring-cloud / spring-cloud-netflix

Integration with Netflix OSS components
http://cloud.spring.io/spring-cloud-netflix/
Apache License 2.0
4.88k stars 2.44k forks source link

About RefreshScopeRefreshedEvent #4283

Open shawnplay opened 6 months ago

shawnplay commented 6 months ago

I found that the propagation of any RefreshScopeRefreshedEvent event will cause Eureka to restart. I think this is unreasonable. The event object already contains the name of the configuration object refreshed. You should check whether this name belongs to you before restarting.

image
shawnplay commented 1 month ago

@OlgaMaciaszek Hi, is there any update?

OlgaMaciaszek commented 1 month ago

Hi @shawnplay, I hope we'll be able to discuss this at today's team meeting. Will post any updates here.

OlgaMaciaszek commented 1 month ago

Hi @shawnplay - what is your specific scenario here? Please provide more detail or some code snippet of how you would like to use the name in your usecase.

shawnplay commented 4 weeks ago

I am using hot update of spring cloud config, but this event is triggered, causing my eureka instance to experience a brief restart

OlgaMaciaszek commented 3 weeks ago

We are still not sure, how you propose to handle this event based on name (against what to check the name of the event). Do you have any suggestions?

shawnplay commented 3 weeks ago

I'm wondering, why do you need to listen to the RefreshScopeRefreshedEvent event and then re-register the Eureka instance?