search

spring-cloud / spring-cloud-open-service-broker

Spring Cloud project for creating service brokers that conform to the Open Server Broker API specification
https://spring.io/projects/spring-cloud-open-service-broker
Apache License 2.0
168 stars 118 forks source link

Service instance labeling #348

Open zoharyehezkely opened 2 years ago

zoharyehezkely commented 2 years ago

Hi,

Following this issue: https://github.com/spring-cloud/spring-cloud-open-service-broker/issues/311 Regarding support for the labeling service instances. I saw that in OSB master, fetching a Service Instance returns also the metadata https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#fetching-a-service-instance

Is this implementation planned for the next release?

Thanks, Zohar.

zoharyehezkely commented 2 years ago

Hi,

I have an implementation ready here: https://github.com/zoharyehezkely/spring-cloud-open-service-broker/commit/f7650699631079ecf47a7bee3e693258d2aef475

Can someone assist with merging it to master? Thanks, Zohar.

zoharyehezkely commented 2 years ago

I have created a PR here: https://github.com/spring-cloud/spring-cloud-open-service-broker/pull/349

royclarkson commented 2 years ago

@zoharyehezkely thanks for the PR. It appears that change to the response body for fetching a service instance is not part of OSB API 2.16. Because it hasn't been released as part of a versioned specification, we can't include yet. Anything that is unreleased in master can potentially change, even if unlikely. We'll be happy to merge this once it is included in a released spec.

zoharyehezkely commented 2 years ago

@royclarkson - Any idea when the next OSB release is due?

Thanks, Zohar.

zoharyehezkely commented 2 years ago

Hi @royclarkson, There is a PR for OSB API 2.17 waiting for reviewers: https://github.com/openservicebrokerapi/servicebroker/pull/751 I was told there are 2 people on the committee from vmware. Can you check from your side if it is possible to notify them for assistance here?

Thanks, Zohar.

zoharyehezkely commented 2 years ago

Hi @royclarkson OSB 2.17 has been released. https://github.com/openservicebrokerapi/servicebroker/tree/v2.17

Regards, Zohar.

zoharyehezkely commented 2 years ago

Hi,

Any updates on this issue?

Regards, Zohar.

zoharyehezkely commented 2 years ago

Hi @royclarkson Any new updates on this issue?

Thanks, Zohar.

royclarkson commented 2 years ago

@zoharyehezkely we have to finalize the OSB 2.16 support first in a release, and then I'll get this added for future 2.17 support. It will probably be a version 4.1. Thanks for your patience.