search

spring-cloud / spring-cloud-open-service-broker

Spring Cloud project for creating service brokers that conform to the Open Server Broker API specification
https://spring.io/projects/spring-cloud-open-service-broker
Apache License 2.0
167 stars 118 forks source link

Generic exception handler prevents from using custom exceptions #90

Closed ihrigb closed 6 years ago

ihrigb commented 6 years ago

Hi Guys,

I found that the custom exception handler at https://github.com/spring-cloud/spring-cloud-open-service-broker/blob/master/spring-cloud-open-service-broker-core/src/main/java/org/springframework/cloud/servicebroker/controller/BaseController.java#L217 prevents from using custom exceptions and handle their outcome (HTTP-Status).

E.g. I would like to enable @ResponseStatus at my exceptions and handle that with a custom @ControllerAdvice. But exceptions are already being handled within the BaseController.

If you agree, this is something that could be adopted, I can contribute some code.

BR, Benjamin

scottfrederick commented 6 years ago

@ihrigb That sounds like a legitimate issue to address. We'd be interested to see a solution that solves the problem for you.

scottfrederick commented 6 years ago

Fixed via #96