search

spring-cloud / spring-cloud-openfeign

Support for using OpenFeign in Spring Cloud apps
Apache License 2.0
1.17k stars 756 forks source link

PlaytikaOSS feign-reactive does not support spring boot 3.2.x #1002

Closed tomaszwasik closed 3 months ago

tomaszwasik commented 3 months ago

Hello, based on https://docs.spring.io/spring-cloud-openfeign/docs/current/reference/html/#reactive-support it is recommended to use feign-reactive in Spring boot WebFlux projects.

1.19. Reactive Support As the OpenFeign project does not currently support reactive clients, such as Spring WebClient, neither does Spring Cloud OpenFeign.We will add support for it here as soon as it becomes available in the core project.

Until that is done, we recommend using feign-reactive for Spring WebClient support.

It was working perfectly until upgrade to spring boot 3.2.x. After upgrade application doesn't work due to:

java.lang.IllegalStateException: Error processing condition on org.springframework.boot.autoconfigure.context.PropertyPlaceholderAutoConfiguration.propertySourcesPlaceholderConfigurer ... Caused by: java.lang.IllegalArgumentException: Invalid value type for attribute 'factoryBeanObjectType': java.lang.String

proper bug ticket was raised in feign-client repository: https://github.com/PlaytikaOSS/feign-reactive/issues/651

The problem is that the bug ticket was created on 08.12.2023. A fix was proposed several days after the ticket was opened. However, so far, there has been no action taken by the repository owner. Alternative forks and solutions have already emerged, yet feign-reactive from PlaytikaOSS still appears in the Spring documentation as recommended. What should we do in such a situation? I would rather like to use libraries officially recommended by Spring.

OlgaMaciaszek commented 3 months ago

Thanks @tomaszwasik. PlayatikaOSS is an independent org. Spring Cloud OpenFeign is now in maintenance only mode (we're suggesting migrating over to Spring interface clients). I will update the documentation. Closing in favour of https://github.com/spring-cloud/spring-cloud-openfeign/issues/968.