search

spring-cloud / spring-cloud-openfeign

Support for using OpenFeign in Spring Cloud apps
Apache License 2.0
1.17k stars 756 forks source link

Add @QueryMap mapEncoder attribute #1013

Open galaxy-sea opened 3 months ago

galaxy-sea commented 3 months ago

Referenced feign#2098. I like this feature♥️.

galaxy-sea commented 2 months ago

hello @OlgaMaciaszek , Can this PR be merged before the next release version? This feature allows for more flexible transformer DTO.

OlgaMaciaszek commented 2 months ago

Thanks for the PR, @galaxy-sea. We will definitely review it before the next release (not coming till mid May).

OlgaMaciaszek commented 2 months ago

Make sure to document your feature in spring-cloud-openfeign.adoc.

galaxy-sea commented 2 months ago

hello @OlgaMaciaszek , I will change the implementation to @BaseQueryMapEncoder

galaxy-sea commented 2 months ago

opt-in property flag

hi @OlgaMaciaszek , I don't think it's necessary to add opt in property flags, just using bean annotated as @ BaseQueryMapEncoder would be more reasonable

OlgaMaciaszek commented 2 months ago

@galaxy-sea the idea is to maintain it backwards compatible since we're not waiting for the major - the behaviour should not cause any breaking changes for existing users, hence the flag.