Open fer1979 opened 3 months ago
@jonatan-ivanov, could you take a look at this issue?
Thank you for the issue. There were a quite a few improvements in the auto-configuration in the past year:
logging.pattern.level
is not needed anymoreMicrometerCapability
you only need to io.github.openfeign:feign-micrometer'
CorrelationScopeCustomizer
is not needed either though I'm not sure since I'm not 100% what you are trying to do but would you please try without it?We have a "real-world" demo with feign (with okhttp) where this works, please feel free to take a look: https://github.com/jonatan-ivanov/teahouse. We also have a simple sample: https://github.com/micrometer-metrics/micrometer-samples/tree/main/openfeign
If after looking at these apps, this is still not working for you, could you please provide a minimal sample project to reproduce this issue so we can more easily investigate and ensure any fix is working properly for your use case?
(Fyi: your link to the Boot issue was broken, I fixed it.)
If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.
With sprint boot 3.1.5 in two microservices, one using FeignClient to request to the other microservice , I have this properties configuration in both microservices:
I have next library in both poms:
I have this FeignConfiguration lets called in microservice A to get the context propagated to the microservice B:
I have this in order to log PARENT_ID in both microservices and is working fine:
The problem is when microservice A calls microservice B, traceId is propagated but I dont see in microservice B in the logs the spanId or parentId from the feign client logs in microservice A.
First of all, I read about Spring Boot 3.x does not allow joining of spans. But with the brave configuration is supposed I can get it according to this https://github.com/spring-projects/spring-boot/pull/35165, right?
Thanks!