search

spring-cloud / spring-cloud-openfeign

Support for using OpenFeign in Spring Cloud apps
Apache License 2.0
1.22k stars 786 forks source link

SpringQueryMap is ignored when used with Pageable #842

Closed philippeu closed 1 year ago

philippeu commented 1 year ago

@SpringQueryMap is ignored when method includes Pageable

Page<Dto> list(@SpringQueryMap Pojo pojo, Pageable pageable)

this has been introduced in version 3.1.6 by https://github.com/spring-cloud/spring-cloud-openfeign/issues/753

paramIndex is set always to Pageable causing PageableSpringQueryMapEncoder to ignore @SpringQueryMap

OlgaMaciaszek commented 1 year ago

Thanks, @philippeu. Possibly a regression. Will verify this.