search

spring-cloud / spring-cloud-openfeign

Support for using OpenFeign in Spring Cloud apps
Apache License 2.0
1.18k stars 758 forks source link

Spring version upgrade broke FeignClient loadbalancing #981

Closed tyhennig closed 4 months ago

tyhennig commented 5 months ago

Describe the bug

Hello, I recently upgraded a project from Spring Boot version 2.6.8 -> 3.1.3 and Spring Cloud version 2021.0.0 -> 2022.0.3

We had been utilizing the Spring Cloud Loadbalancer to provide custom loadbalancing logic to our feign clients with the following configuration (based on code found here https://www.tutorialspoint.com/spring_cloud/spring_cloud_load_balancer.htm).

@LoadBalancerClient(name = "my-service", configuration = CustomConfiguration.class)
@FeignClient(name = "my-service")
public interface MyServiceClient
{
   ...
}

After completing the version upgrade, it appears the default Round-Robin load balancing is always used as opposed to the CustomConfiguration.class.

I have been unable to find anything in the release notes for either OpenFeign or Cloud Loadbalancer to indicate a breaking change, so I was hoping for some insight here.

Thank you!

OlgaMaciaszek commented 5 months ago

Hello @tyhennig, thanks for reporting the issue. Neither of the versions you've listed is in OSS support anymore. Please upgrade to Spring Cloud 2023.0.0 and check if the issue persists. If yes, please provide a minimal, complete, verifiable example that reproduces the issue.

spring-cloud-issues commented 4 months ago

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

spring-cloud-issues commented 4 months ago

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.