spring-cloud / spring-cloud-release

Spring Cloud Release Train - dependency management across a wide range of Spring Cloud projects.
http://projects.spring.io/spring-cloud
Apache License 2.0
874 stars 179 forks source link

Spring Cloud Commons Bootstrap is not enabled by default for Spring-Cloud-2022.0 #273

Open fdurantsq opened 11 months ago

fdurantsq commented 11 months ago

Describe the bug Really I'm just suggesting changes to breaking changes list, and to add spring-cloud-bootstrap-starter to spring-cloud-commons documentation so people can more easily make upgrades or get started with using Bootstrap configurations. Specifically:

spring.config.use-legacy-processing=true no longer enables bootstrap because of changes in Spring Boot 3.0. Please use spring.cloud.bootstrap.enabled=true.

Does not adequately describe the side-effects of the changeset here

Source: https://github.com/spring-cloud/spring-cloud-release/wiki/Spring-Cloud-2022.0-Release-Notes

Steps to reproduce:

Expectations:

Actual behavior:

spencergibb commented 11 months ago

I disagree. Both methods should work. If the property does not work it is a bug. How are you setting the property?

spencergibb commented 11 months ago

I didn't fully read the last comment. It has to be a system property, environment variable or cli argument