search

spring-cloud / spring-cloud-schema-registry

A schema registry implementation for Spring Cloud Stream
47 stars 28 forks source link

Investigate backward compatibility support in ConfluentSchemaRegistryClient #10

Closed sabbyanandan closed 4 years ago

sabbyanandan commented 5 years ago

Find out what version of the schema registry that includes the breaking changes to the REST APIs.

frombrest commented 4 years ago

I suppose that ConfluentSchemaRegistryClient:153

@Override
public String fetch(int id) {
        String path = String.format("/schemas/%d", id);
        HttpHeaders headers = new HttpHeaders();

Should be

        String path = String.format("/schemas/ids/%d", id);

Schema Registry API endpoint: https://docs.confluent.io/current/schema-registry/develop/api.html#schemas

sabbyanandan commented 4 years ago

Thanks for fixing this, @frombrest! Addressed in https://github.com/spring-cloud/spring-cloud-schema-registry/commit/0cdff772bf62c33c8b578b143f5184666842ded0.