search

spring-cloud / spring-cloud-schema-registry

A schema registry implementation for Spring Cloud Stream
47 stars 28 forks source link

Document schemaImport #4

Open sabbyanandan opened 5 years ago

sabbyanandan commented 5 years ago

@dmarmugi commented on Wed Apr 10 2019

dmarmugi @dmarmugi Mar 08 15:41 Hi folks. I’m working on upgrading from Finchley to Greenwich release train and getting an error:

Error creating bean with name 'avroSchemaMessageConverter' defined in class path resource [org/springframework/cloud/stream/schema/avro/AvroMessageConverterAutoConfiguration.class]: Invocation of init method failed; nested exception is org.apache.avro.SchemaParseException: Can't redefine: com.example.avro.SomeSchema

Chasing this led me to 829604ae (fixing #1517) which seems to have added a spring.cloud.stream.schema.avro.schemaImport field to enable separating dependent schemas from base ones. Just a heads up that documentation of this change seems to be missing in https://docs.spring.io/spring-cloud-stream/docs/current/reference/htmlsingle/

@olegz commented on Wed Apr 10 2019

Good point, will take care of it

sabbyanandan commented 4 years ago

Maybe there's an opportunity to consolidate both into a single property (it is already treated that way internally), so let's review it once again and make a decision.