search

spring-cloud / spring-cloud-schema-registry

A schema registry implementation for Spring Cloud Stream
47 stars 27 forks source link

Consider publishing test-jar #42

Open Walliee opened 4 years ago

Walliee commented 4 years ago

I was looking to stub SchemaRegistryClient and stumbled across StubSchemaRegistryClient.

I think this would be nice to share with spring-cloud-schema-registry consumers for easier testing. Not sure if there are other sharable test utilities in the test folder.

Alternatively, an in-memory SchemaRegistryClient could be added to the main jar.

nhomble commented 4 years ago

I'd be interested in this although I would point out that the name of the class is misleading. It's under their avro package and assumes avro schemas

        if (!AvroSchemaRegistryClientMessageConverter.AVRO_FORMAT
                .equals(schemaReference.getFormat())) {
            throw new IllegalArgumentException("Only 'avro' is supported by this client");
        }