search

spring-cloud / spring-cloud-schema-registry

A schema registry implementation for Spring Cloud Stream
47 stars 28 forks source link

Invalid scope 'tests' in registry-client pom for dependency 'jackson-dataformat-xml' #51

Open Chr3is opened 3 years ago

Chr3is commented 3 years ago

The registry-client pom contains an invalid declared test dependency

<dependency>
    <!-- used for testing https://github.com/spring-cloud/spring-cloud-schema-registry/issues/19 -->
    <groupId>com.fasterxml.jackson.dataformat</groupId>
    <artifactId>jackson-dataformat-xml</artifactId>
    <scope>tests</scope>
</dependency>

mvn dependency:tree shows

[INFO] +- org.springframework.cloud:spring-cloud-schema-registry-client:jar:1.1.0:compile
[INFO] |  +- org.springframework:spring-messaging:jar:5.3.3:compile
[INFO] |  +- org.springframework:spring-web:jar:5.3.3:compile
[INFO] |  +- com.fasterxml.jackson.core:jackson-databind:jar:2.11.4:compile
[INFO] |  +- org.apache.avro:avro:jar:1.10.0:compile
[INFO] |  \- com.fasterxml.jackson.dataformat:jackson-dataformat-xml:jar:2.11.4:tests

Scope should be 'test'.

Temporary fix is to exclude the dependency

<dependency>
    <groupId>org.springframework.cloud</groupId>
    <artifactId>spring-cloud-schema-registry-client</artifactId>
    <version>1.1.0</version>
    <exclusions>
        <exclusion>
            <groupId>com.fasterxml.jackson.dataformat</groupId>
            <artifactId>jackson-dataformat-xml</artifactId>
        </exclusion>
    </exclusions>
</dependency>