Closed fiidim closed 3 years ago
Ah this was a mistake we/I made when moving image generation from maven plugin to paketo. scdf/skipper 2.6.x/2.5.x were on jdk8, scdf/skipper 2.7.x/2.6.x were on jdk11. I think we were supposed to be jdk8 even on 2.7.x as we were afraid to pump up but looks like we silently went on with jdk11.
Having said that, we can go back to jdk11 in next maintenance release.
Sorry for this, and thanks for reporting.
In a meanwhile, I did manually push new images to dockerhub with different tag names which now have jdk11(if you want to try those)
pack build \
--path spring-cloud-skipper-server-2.7.0.jar \
--builder gcr.io/paketo-buildpacks/builder:0.1.99-base \
--env BP_JVM_VERSION=11 springcloud/spring-cloud-skipper-server:2.7.0-jdk11
pack build \
--path spring-cloud-dataflow-server-2.8.0.jar \
--builder gcr.io/paketo-buildpacks/builder:0.1.99-base \
--env BP_JVM_VERSION=11 springcloud/spring-cloud-dataflow-server:2.8.0-jdk11
pack build \
--path spring-cloud-dataflow-composed-task-runner-2.8.0.jar \
--builder gcr.io/paketo-buildpacks/builder:0.1.99-base \
--env BP_JVM_VERSION=11 springcloud/spring-cloud-dataflow-composed-task-runner:2.8.0-jdk11
Thanks for looking at this. It's an interesting dilemma though. If skipper
itself needs a 1.8
runtime, but the apps
that run in the skipper
image need a higher minimum runtime, it almost seems that the jre
or build image needs to have an option runtime version for the apps.
It looks like other people are/were doing the same thing. This issue talks about needing 14
, and this issue reports a warning with 11
.
In the meantime, I will try out your new images and let you know. When I did the upgrade I also hit an issue with docker-compose.yml
and local maven repositories. I'm not sure whether the latest docker-compose.yml
file introduced something ahead of the build or not. Definitely related to having /home/cnb
vs /root
for mounting the local repository.
Change looks good (using -jdk11 suffixed images). The only noteworthy difference is an additional innocuous stderr
message:
stderr:
Picked up JAVA_TOOL_OPTIONS: -Djava.security.properties=/layers/paketo-buildpacks_bellsoft-liberica/java-security-properties/java-security.properties -agentpath:/layers/paketo-buildpacks_bellsoft-liberica/jvmkill/jvmkill-1.16.0-RELEASE.so=printHeapHistogram=1 -XX:ActiveProcessorCount=8 -XX:MaxDirectMemorySize=10M -Xmx16237962K -XX:MaxMetaspaceSize=186629K -XX:ReservedCodeCacheSize=240M -Xss1M -Dorg.springframework.cloud.bindings.boot.enable=true
I've always built and deployed SCDF apps using openjdk 11.0.8. Prior to 2.7 the image my apps deployed ok. After moving to 2.7 I now get:
Not sure why the project went backwards a version, and I haven't found release notes on how to introduce newer runtimes. Did I miss something?
Was: