spring-cloud / spring-cloud-skipper

A package manager that installs, upgrades, and rolls back Spring Boot applications on multiple Cloud Platforms.
http://cloud.spring.io/spring-cloud-skipper/
Apache License 2.0
111 stars 78 forks source link

spring-cloud-skipper-1034 Tests fail under Windows #1035

Closed corneil closed 2 years ago

corneil commented 2 years ago

Remove CR (\r) for comparison to files.

onobc commented 2 years ago

Hi @corneil , we typically follow these guidelines for commit messages.

corneil commented 2 years ago

@onobc Is the new commit comment fine?

onobc commented 2 years ago

@onobc Is the new commit comment fine?

Yep those messages look good. We can squash/merge into a single commit before merge which I envision would look something like:

Remove CR (\r) for comparison to files.

Fixes #1034