search

spring-cloud / spring-cloud-skipper

A package manager that installs, upgrades, and rolls back Spring Boot applications on multiple Cloud Platforms.
http://cloud.spring.io/spring-cloud-skipper/
Apache License 2.0
111 stars 78 forks source link

Skipper fails with oauth config #1036

Closed jvalkeal closed 2 years ago

jvalkeal commented 2 years ago

When changing skipper/dataflow deps to 2.9.x/2.10.x in https://github.com/jvalkeal/randomstuff/tree/master/dataflow-keycloak-basic we get:

skipper-server-keycloak1 | ***************************
skipper-server-keycloak1 | APPLICATION FAILED TO START
skipper-server-keycloak1 | ***************************
skipper-server-keycloak1 | 
skipper-server-keycloak1 | Description:
skipper-server-keycloak1 | 
skipper-server-keycloak1 | The dependencies of some of the beans in the application context form a cycle:
skipper-server-keycloak1 | 
skipper-server-keycloak1 |    org.springframework.security.config.annotation.web.configuration.WebSecurityConfiguration
skipper-server-keycloak1 | ???????
skipper-server-keycloak1 | |  org.springframework.cloud.skipper.server.config.security.SkipperOAuthSecurityConfiguration
skipper-server-keycloak1 | ?     ?
skipper-server-keycloak1 | |  org.springframework.boot.autoconfigure.web.servlet.WebMvcAutoConfiguration$EnableWebMvcConfiguration
skipper-server-keycloak1 | ?     ?
skipper-server-keycloak1 | |  org.springframework.security.config.annotation.web.configuration.OAuth2ClientConfiguration$OAuth2ClientWebMvcSecurityConfiguration
skipper-server-keycloak1 | ???????

Looks like our acc/ci tests didn't catch this case.