spring-cloud / spring-cloud-skipper

A package manager that installs, upgrades, and rolls back Spring Boot applications on multiple Cloud Platforms.
http://cloud.spring.io/spring-cloud-skipper/
Apache License 2.0
111 stars 78 forks source link

Remove deprecated dependency spring-security-oauth2 #1041

Closed corneil closed 2 years ago

corneil commented 2 years ago

Remove org.springframework.security.oauth:spring-security-oauth2 and tests that require the deprecated project.

corneil commented 2 years ago

@corneil changes look straight-forward. My one question w/ this removal is where will be verifying OAuth2 behavior now? ATs? Do we need a follow on ticket(s) for this work if so?

Had a chat with @jvalkeal, these test are invalid because the security implementation has actually been migrated away from the deprecated library. The integration test in Dataflow does complete test along with running Keycloak.

corneil commented 2 years ago

Resolved #1042 and https://github.com/spring-cloud/spring-cloud-common-security-config/issues/93