search

spring-cloud / spring-cloud-skipper

A package manager that installs, upgrades, and rolls back Spring Boot applications on multiple Cloud Platforms.
http://cloud.spring.io/spring-cloud-skipper/
Apache License 2.0
111 stars 78 forks source link

Shell repo add/delete commands broken #632

Open jvalkeal opened 6 years ago

jvalkeal commented 6 years ago

Some issues with these commands

skipper:>repo delete --name xxxx
404 
Details of the error have been omitted. You can use the stacktrace command to print the full stacktrace.
skipper:>stacktrace 
org.springframework.web.client.HttpClientErrorException: 404 
    at org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:85)
    at org.springframework.cloud.skipper.client.SkipperClientResponseErrorHandler.handleError(SkipperClientResponseErrorHandler.java:78)
ilayaperumalg commented 6 years ago

It looks like the REST repository for Skipper Repository doesn't expose the save and delete method invocations as per this.

I think we had a reason not to expose these endpoints as we wanted to avoid user deleting the default local repository etc., Perhaps, we can add some check and allow these methods to be exposed?

What do you think @jvalkeal @markpollack ?

markpollack commented 6 years ago

As I recall, I purposely left this not exposed and thought that whoever started the skipper server would edit the yaml file. I suppose the right way is to add a role to that endpoint. Can we push this off to a backport targeting 1.0.6 so we can go ahead with the overdue scdf 1.5.1 release?

markpollack commented 6 years ago

maybe remove the command or just log a more decent warning short term?

sabbyanandan commented 6 years ago

We will revisit it in the context of RBAC in future.