GH-1203: Clean up resources on close. Allow terminating an applicatio…

spring-cloud / spring-cloud-stream-binder-kafka

Spring Cloud Stream binders for Apache Kafka and Kafka Streams

Apache License 2.0

331 stars 301 forks source link

GH-1203: Clean up resources on close. Allow terminating an applicatio… #1213

Closed tszmytka closed 2 years ago

tszmytka commented 2 years ago

Seems the issue in #1203 has not been identified correctly (at least partly). There still is a bug where cleanly closing your application by invoking org.springframework.context.ConfigurableApplicationContext#close is not possible. Other Spring resources are closed but the scheduler instantiated in org.springframework.cloud.stream.binder.kafka.KafkaBinderMetrics#bindTo remains hanging and keeps the JVM process running.

This PR actually fixes that.

tszmytka commented 2 years ago

@sobychacko Would you be able to find a moment and review?

sobychacko commented 2 years ago

@tszmytka This repository is now moved to the core Spring Cloud Stream repository. See the announcements. Could you close this PR and then re-issue it against the proper repository? Thanks.

tszmytka commented 2 years ago

This repository is now moved to the core Spring Cloud Stream repository

Thanks for the info and sorry - I completely missed that. Guess I saw commits in this repository a few days ago so it hasn't occurred to me you moved to the central one.