search

spring-cloud / spring-cloud-stream-samples

Samples for Spring Cloud Stream
Apache License 2.0
959 stars 677 forks source link

README updated and docker-compose file cleanup #245

Closed dduehr closed 1 year ago

dduehr commented 1 year ago

The target Jar was misspelled in the README.md files of the directories processor-samples/reactive-processor-kafka and processor-samples/reactive-processor-rabbit.

So I corrected the processor-samples/reactive-processor-kafka/README.md instruction from java -jar target/reactive-processor-0.0.1-SNAPSHOT-kafka.jar to java -jar target/reactive-processor-kafka-0.0.1-SNAPSHOT.jar and made a corresponding correction to processor-samples/reactive-processor-rabbit/README.md, too.

Since there are already distinct directories for the Kafka and RabbitMQ binding examples (i.e. processor-samples/reactive-processor-kafka and processor-samples/reactive-processor-rabbit) I removed the docker-compose-rabbit.yml file from the Kafka binding example directory processor-samples/reactive-processor-kafka and updated it's README.md accordingly.

sobychacko commented 1 year ago

@dduehr Thanks for the cleanup. Merged the PR upstream. We are in the process of revamping the sample repository. We may put this sample under a new branch.