search

spring-cloud / spring-cloud-stream-samples

Samples for Spring Cloud Stream
Apache License 2.0
956 stars 676 forks source link

RecordRecoverableProcessor and DltAwareProcessor example #254

Closed StevenPG closed 7 months ago

StevenPG commented 8 months ago

Included junit and readme update

sobychacko commented 8 months ago

@StevenPG Thanks for the sample. I left some minor comments. Otherwise, it looks great.

StevenPG commented 8 months ago

Updated in 391f70fbd7ddef62de22c216276e38b246969f9e @sobychacko , let me know what you think!

sobychacko commented 8 months ago

I am getting compilation errors when running the build from the kafka-streams-recoverable directory: ./mvnw clean package. Is it working for you? Could you take a look?

StevenPG commented 8 months ago

Should be resolved now @sobychacko apologies for the issue, I did my final test via the IDE only and not through CLI. Some wires were crossed dependency-wise. Validated locally with ./mvnw clean package

image
StevenPG commented 8 months ago

@sobychacko let me know if things look good on your end!

sobychacko commented 8 months ago

@StevenPG I am on PTO at the moment and will be back next week. I will continue looking at the PR when I am back. Sorry for the delay.

StevenPG commented 8 months ago

@sobychacko Not a problem! Open source is a LOT of work and I just didn't want it to be missed. Much appreciated and thank you!

sobychacko commented 7 months ago

@StevenPG One minor comment; otherwise, the PR is ready to be merged.

sobychacko commented 7 months ago

Thanks, @StevenPG, for the PR. It is now merged upstream. I'm sorry for the delay in reviewing and merging it.

StevenPG commented 7 months ago

Not a problem, thank you!!

sobychacko commented 6 months ago

@StevenPG I want to invite your attention to this discussion and see if you have any thoughts: https://github.com/spring-projects/spring-kafka/discussions/3073. Feel free to chime in on the discussion.