Closed StevenPG closed 7 months ago
@StevenPG Thanks for the sample. I left some minor comments. Otherwise, it looks great.
Updated in 391f70fbd7ddef62de22c216276e38b246969f9e @sobychacko , let me know what you think!
I am getting compilation errors when running the build from the kafka-streams-recoverable
directory: ./mvnw clean package.
Is it working for you? Could you take a look?
Should be resolved now @sobychacko apologies for the issue, I did my final test via the IDE only and not through CLI. Some wires were crossed dependency-wise.
Validated locally with ./mvnw clean package
@sobychacko let me know if things look good on your end!
@StevenPG I am on PTO at the moment and will be back next week. I will continue looking at the PR when I am back. Sorry for the delay.
@sobychacko Not a problem! Open source is a LOT of work and I just didn't want it to be missed. Much appreciated and thank you!
@StevenPG One minor comment; otherwise, the PR is ready to be merged.
Thanks, @StevenPG, for the PR. It is now merged upstream. I'm sorry for the delay in reviewing and merging it.
Not a problem, thank you!!
@StevenPG I want to invite your attention to this discussion and see if you have any thoughts: https://github.com/spring-projects/spring-kafka/discussions/3073. Feel free to chime in on the discussion.
Included junit and readme update