search

spring-cloud / spring-cloud-vault

Configuration Integration with HashiCorp Vault
http://cloud.spring.io/spring-cloud-vault/
Apache License 2.0
275 stars 152 forks source link

Add ability to configure client TLS enabled protocol versions and cipher suites via Spring properties #581

Closed mryangza closed 3 years ago

mryangza commented 3 years ago

In https://github.com/spring-projects/spring-vault/issues/635 support was added for configuring the enabled client TLS protocols and cipher suites to be configured via Spring application properties. It would be great if we could also configure these via Spring application properties for the Spring Cloud Vault client.

The org.springframework.vault.config.EnvironmentVaultConfiguration.sslConfiguration() was updated to set protocol and cipher suites on the org.springframework.vault.support.SslConfiguration instance returned. The org.springframework.cloud.config.server.environment.vault.SpringVaultClientConfiguration.sslConfiguration() method could be updated to do the same.

mp911de commented 3 years ago

That's in place now.

mryangza commented 3 years ago

Awesome, thank you! I realized now that org.springframework.cloud.config.server.environment.vault.SpringVaultClientConfiguration is actually part of spring-cloud-config. I'll submit a feature request there too.