search

spring-cloud / spring-cloud-vault

Configuration Integration with HashiCorp Vault
http://cloud.spring.io/spring-cloud-vault/
Apache License 2.0
272 stars 151 forks source link

No error if connection failed #592

Closed cweber26 closed 3 years ago

cweber26 commented 3 years ago

Describe the bug I just migrate from spring-cloud-starter-vault-config 2.2.7.RELEASE to 3.0.1 and done the breaking change. The connection is done correctly but I don't see anymore vault connection in my console.

Sample If I set intentionally a wrong token I don't get any WARN or ERROR log about it when I start my server. With the previous release I had this error 12:13:17.853 [reactor-http-nio-1] WARN o.s.v.a.ReactiveLifecycleAwareSessionManager - Cannot enhance VaultToken to a LoginToken: Token self-lookup: Status 403 Forbidden permission denied; nested exception is org.springframework.web.reactive.function.client.WebClientResponseException$Forbidden: 403 Forbidden from GET https://vault-decatec.pp.dktapp.cloud:443/v1/auth/token/lookup-self Even if I set my root log to debug I can't find any log about the vault connection.

That could be pretty annoying for troubleshooting :

I done some research but I have found anything about it ...

Hope this could help to make the project even better :)

nkvaratskhelia commented 3 years ago

You can use the spring.cloud.vault.fail-fast=true property. If there's something wrong with the connection, vault will report it and the application won't start.

cweber26 commented 3 years ago

that exactly what I wanted. thanks for your quick reply! I close the issue