spring-cloud / spring-cloud-vault

Configuration Integration with HashiCorp Vault
http://cloud.spring.io/spring-cloud-vault/
Apache License 2.0
270 stars 151 forks source link

spring.cloud.vault.enabled: false doesn't work in .yml with webflux-netty #674

Closed HelenLorenzo closed 1 year ago

HelenLorenzo commented 1 year ago

Describe the bug We have some apllication with mvc-tomcat and when we want to disable Vault we use in the applicatoin.yml spring.cloud.vault.enabled: false. it works fine. But, in other application with webflux-netty we only disabled Vault using the spring.cloud.vault.enabled: false on bootstap not in .yml and I don't know why. Doen't work this configuration on .yml

Sample If possible, please provide a test case or sample application that reproduces the problem. This makes it much easier for us to diagnose the problem and to verify that we have fixed it.

mp911de commented 1 year ago

We need a bit more context to be able to diagnose. Ideally, provide a minimal reproducer that can show the problem. Also, we need to know which versions of Spring Cloud and Spring Boot you're using as we introduced over time support to leverage the Config Data API that doesn't require bootstrap API usage.

HelenLorenzo commented 1 year ago

The managed version is 3.1.1 The artifact is managed in org.springframework.cloud:spring-cloud-vault-dependencies:3.1.1 The managed version is 2.6.13 The artifact is managed in org.springframework.boot:spring-boot-dependencies:2.6.13 we have imported:

org.springframework.cloud spring-cloud-starter-vault-config

And we have disabled vault. But using spring.cloud.vault.enabled: false in ymls doesn't work, on bootstrap yes.

HelenLorenzo commented 1 year ago

I found the error. The pom had imported:

org.springframework.cloud spring-cloud-starter-bootstrap

Thanks for your support!