Leases no longer revoked after stopping `SecretLeaseContainer` - Githubissues

spring-cloud / spring-cloud-vault

Configuration Integration with HashiCorp Vault

http://cloud.spring.io/spring-cloud-vault/

Apache License 2.0

270 stars 151 forks source link

Leases no longer revoked after stopping `SecretLeaseContainer` #713

Closed NoureddineDahmen closed 6 months ago

NoureddineDahmen commented 6 months ago

Hello. It was noted that since the migration to SB3.2, our client vault does not call to revoke the leases vault for Postgresql Base during the gracefull shutdown of our application.

The version of spring-vault-core is 3.0.2 The version of spring-cloud-vault-config-databases and spring-cloud-starter-vault-config are 4.0.1

We use config import for configuration properties vault :

config: import:

vault://secret/XXXX/XXX/XXXX/applis
vault://objsto/XXXXXX
optional:vault://

Do you know if this is a problem with migration to SB3? Thanks in advance,

mp911de commented 6 months ago

We introduced in the latest version means to communicate login token expiry to the secret lease container. I wonder whether this has introduced an undesired effect.

NoureddineDahmen commented 6 months ago

HELLO can you confirm for us that this is a régression please thank you in advance

mp911de commented 6 months ago

That's fixed now via spring-projects/spring-vault#844

NoureddineDahmen commented 5 months ago

Hello , We tested with version 3.1.1 and unfortunately we still noticed the issue. @mp911de