search

spring-cloud / spring-cloud-zookeeper

Spring Cloud Zookeeper
http://cloud.spring.io/spring-cloud-zookeeper/
Apache License 2.0
555 stars 413 forks source link

Health check using spring-boot actuator health endpoint #266

Open MorrisZ opened 4 years ago

MorrisZ commented 4 years ago

Problem I have a customized HealthIndicator that simply marks the service as 'DOWN'. But when I checked the znode data, it showed that 'instance_status' was 'UP'.

When using spring-cloud-gateway along with zookeeper registry, I expect that it would NOT forward requests to a service being 'DOWN'. But for now it seems impossible.

JWThewes commented 3 years ago

I solved that on my own by using a scheduler and querying the health endpoint. Would happily provide a PR for this if this is a way to go.

JWThewes commented 3 years ago

@spencergibb Any interest that I provide a PR? Or is this not the way to go?

JWThewes commented 3 years ago

@spencergibb @OlgaMaciaszek Any interest in a PR for this one.

spencergibb commented 3 years ago

Yes, PRs welcome, that's why it's labeled "help wanted"

JWThewes commented 3 years ago

Took some time because pandemic times require me too be there for my children. But now I've finally provided a solution for this.

spencergibb commented 3 years ago

Totally understandable