Move Dependency functionality to other projects

spring-cloud / spring-cloud-zookeeper

Spring Cloud Zookeeper

http://cloud.spring.io/spring-cloud-zookeeper/

Apache License 2.0

555 stars 412 forks source link

Move Dependency functionality to other projects #33

Open spencergibb opened 9 years ago

spencergibb commented 9 years ago

*Rule*, *Ribbon*, *LoadBalancer* and *Feign* to spring-cloud-netflix
*ZookeeperDependenc* to spring-cloud-commons minus Zookeeper
move watcher package to spring-cloud-commons, DefaultDependencyWatcher -> ZookeeperDependencyWatcher
watcher.presence has curator classes as part of the interface, so initial this won't move.

spencergibb commented 9 years ago

/cc @marcingrzejszczak

marcingrzejszczak commented 9 years ago

Makes perfect sense - I'd add StickyRule as well to spring-cloud-netflix.

Do you have an idea already how to deal with the load balancer in the Dependency?

Once you move I'll add the missing tests - just point where ok?

spencergibb commented 9 years ago

Yeah, I have it in *Rule* :-)

spencergibb commented 9 years ago

We currently have a way to configure ribbon, but it's by putting an @Bean in a configuration. If there's not a bean if falls back to netflix and tries to instantiate a class. I think there needs to be a config option like you have in dependency, but NOT in dependency. Not sure how it will look yet.