search

spring-cloud / stream-applications

Functions and Spring Cloud Stream Applications for data driven microservices
https://spring.io/projects/spring-cloud-stream-applications
250 stars 106 forks source link

[CI] Snapshot deploys always using unique version #456

Closed onobc closed 8 months ago

onobc commented 1 year ago

The snapshot libs that are deployed to repo.spring.io/lib-snapshot-local no longer include the "non-unique" version number (aka -4.0.0-SNAPSHOT) but rather always include the timestamp on the version number.

This is a problem when attempting to reference via urls such as in https://github.com/spring-io/dataflow.spring.io/blob/b50a0266d163fee3cf9633c8f834dce5dec25432/paketo/redirect.conf#L8

Need to track down why this is the case. It started when we switched to the new CI system.

I have already verified w/ Trevor that there is nothing on the Artifactory side that is doing the non-unique versioning nor has anything changed on the server in quite some time. This points to the client side deploy being the culprit.

onobc commented 11 months ago

We simply need to make sure that the latest snapshot descriptors have the "-SNAPSHOT" id on Artifactory https://repo.spring.io/ui/native/snapshot/org/springframework/cloud/stream/app/stream-applications-descriptor/2022.0.0-SNAPSHOT/

onobc commented 11 months ago

@corneil can we close this now?

onobc commented 11 months ago

Detaching this from the 4.0.0 milestone as the pieces that are mandatory for 4.0.0 are complete. The *kafka-apps-maven-repo-url.properties and *rabbit-apps-maven-repo-url.properties are not used directly from the UI nor listed in any links on dataflow.spring.io AFAICT. The user can point to them in the UI when adding apps via a http url.

We should still fix this but it should not block the 4.0.0 release.