spring-cloud / stream-applications

Functions and Spring Cloud Stream Applications for data driven microservices
https://spring.io/projects/spring-cloud-stream-applications
252 stars 104 forks source link

GH-275: Mention `ComponentCustomizer` in READMEs #466

Closed artembilan closed 1 year ago

artembilan commented 1 year ago

Fixes https://github.com/spring-cloud/stream-applications/issues/275

Many functions make use of ComponentCustomizer ot let end-user to provide any custom configuration for target component used by the function. First of all for use-case which are not covered by standard configuration properties and secondly for those options which cannot be represented as a configuration option.

artembilan commented 1 year ago

While working on this I asked myself why not every function has this customizer hook? Did we make just a sane choice only for those where not everything can be covered with confit props? Is there any other idea?

onobc commented 1 year ago

While working on this I asked myself why not every function has this customizer hook? Did we make just a sane choice only for those where not everything can be covered with confit props? Is there any other idea?

Yep - sanity. Your exact comment from PR was:

Some modules just does not make sense to modify for more advance customization since all their configuration is covered with plain configuration properties. See splitter-function or wavefront-consumer

artembilan commented 1 year ago

Closed in favor of: https://github.com/spring-cloud/stream-applications/pull/467