High CPU usage when identifying local projects in large multi-project builds

kazuki-ma commented 3 years ago

I noticed that adding spring-boot-dependency plugin makes IntelliJ gradle project reloading longer.

In summary, I found 2 major reason.

Apply maven execution rule is heavy task. (I have no idea now about how to improve it)
VersionConfiguringAction.isDependencyOnLocalProject calls Gradle's .getAllprojects() and it's not optimized for frequent call.

(I wrote some things in https://github.com/spring-gradle-plugins/dependency-management-plugin/issues/288)

This PR introduces a cache of local project names. (This is the same thing of already done for directDependencies https://github.com/spring-gradle-plugins/dependency-management-plugin/blame/master/src/main/java/io/spring/gradle/dependencymanagement/internal/VersionConfiguringAction.java#L86-L96)

This value must be the same in project global but caching it in VersionConfiguringAction is enough for performance.

AS-IS: .getAllprojects() called every project x configuration x dependency TO-BE: .getAllprojects() called every project x configuration (I'm not sure about this)

Profiler result (n = 1)

Condition:

large scale project (modules > 200 & configurations ~ 50 because of applied many plugins)
But set setApplyMavenExclusions(false) for fast configuration reload.

x	Total samples profiler	isDependencyOnLocalProject	ex isDependencyOnLocalProject (calculated)	Reload time on my machine
Before	25,460	12,540	12,920	41s
After	13,042 (-49%)	177	12,865	21s

Frame graph / Before

Frame graph / After

wilkinsona commented 3 years ago

Thanks very much for the pull request, @kazuki-ma.

kazuki-ma commented 3 years ago

I applied it to my project today and got positive feedback from my colleagues. Thank you @wilkinsona.

spring-gradle-plugins / dependency-management-plugin