search

spring-guides / getting-started-guides

Getting Started Guide template :: The template for new guides and also the place to request them.
https://github.com/spring-guides/getting-started-guides/wiki
Apache License 2.0
520 stars 204 forks source link

Scheduling Tasks - complete/src/test/* seems not needed #143

Closed josephzhang999 closed 4 months ago

josephzhang999 commented 3 years ago

In the downloaded source repository for this guide, there are two test files: SchedulingTasksApplicationTest.java, ScheduledTasksTest.java.

The guide doesn't introduce / explain the details in these two files. And they are not needed (without them, the application can still run and print out the current time to the log every 5 seconds).

Therefore, it seems they can be removed from the source repository. The part of "Adding the awaitility Dependency" in the guide can also be removed (I tried, it still works).

Thanks for the consideration. I'm new to Spring so if there is any wrong inputs, please excuse me. Your feedback to this issue is appreciated.

robertmcnees commented 4 months ago

Hi @josephzhang999. Thank you for your issue. You are correct that the gs-scheduling-tasks guide could use some work.

I will close this issue because I believe it is covered under the issues in the gs-scheduling-tasks GitHub repo.

You will be able to track progress by monitoring those issues and the attached PR(s). Thanks again,