search

spring-guides / getting-started-guides

Getting Started Guide template :: The template for new guides and also the place to request them.
https://github.com/spring-guides/getting-started-guides/wiki
Apache License 2.0
521 stars 204 forks source link

Link to "build a classic WAR file" goes to a 404 page #163

Open blackcoder41 opened 2 weeks ago

blackcoder41 commented 2 weeks ago

https://spring.io/guides/gs/accessing-data-jpa

Buzzardo commented 2 weeks ago

We removed that file a while back. The link in the guides should be removed, too. This is a good one for someone who wants a place to get started on contributing to Spring.

robertmcnees commented 2 weeks ago

When the guides are archived, they are usually moved here to the spring-attic. For this particular issue, you can see where jar to war landed.

In the past I've seen this type of issue addressed in the individual repos. So perhaps opening an issue in the specific repository would get a faster response from the community. If it gets tagged with good first issue those usually go pretty fast. This link isn't even the only broken one on the page, as the gemfire link is also broken for the same reason.

If anyone wants to delete this line about building a WAR file, it would be a PR to the shared repository, specifically this file. It would fix a good number of guides I'm guessing.

TejasNarkhede commented 1 week ago

Thank you, @blackcoder41, @Buzzardo, and @robertmcnees, for your helpful insights and guidance on this issue! I’ve submitted a PR to remove the broken link. I really appreciate the direction you provided, which made it easier to tackle this fix. Looking forward to contributing more to the project!

My PR