spring-guides / gs-accessing-data-mysql

Accessing data with MySQL :: Learn how to set up and manage user accounts on MySQL and how to configure Spring Boot to connect to it at runtime.
http://spring.io/guides/gs/accessing-data-mysql/
Apache License 2.0
201 stars 314 forks source link

Change a get to a post when creating a new User #25

Closed CorainChicago closed 5 years ago

CorainChicago commented 5 years ago

When an entity is created in a request, the convention is to use POST. I don't want anyone to pick up bad habit or confusion from the examples.

dsyer commented 5 years ago

Thanks. That makes sense. You forgot to change the README (guide text) to reflect the change.

dsyer commented 5 years ago

Thanks again. The bit you changed doesn't make any sense to me (separate problem). And you didn't actually change the more important bit where there are some sample curl requests. Do you want to do that while the failed build fixes itself (hopefully)?

dsyer commented 5 years ago

Merged in c4b7d7b