search

spring-guides / gs-accessing-data-neo4j

Accessing Data with Neo4j :: Learn how to persist objects and relationships in Neo4j's NoSQL data store.
http://spring.io/guides/gs/accessing-data-neo4j/
Apache License 2.0
29 stars 49 forks source link

Documentation and code was not sufficiently updated from copy/paste to function #34

Closed clayharris closed 1 year ago

clayharris commented 4 years ago

This example appears to be an incomplete port of a copy-paste from a MySql example. 2 main (semi-breaking) reasons noted:

  1. Initial Start with Spring Initializr instructions list the wrong dependencies. It specifies JPA and MySQL, but I think it only needs Neo4J, based on the example pom and build.gradle files.

  2. Under the Create a Simple Query section, it states that that PersonRepository (which is missing display example) extends GraphRepository. But it currently does not - it simply extends CrudRepository, which I don't believe is sufficient. I tried changing it to GraphRepository locally, but it could not find the class. Should it be Neo4jRepository?

Buzzardo commented 1 year ago

I was all set to fix it, only to discover that I had fixed it in subsequent commits. Thanks, though, and sorry about the delay.